Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hdparm: name -> pname #101582

Merged
merged 1 commit into from Oct 25, 2020
Merged

hdparm: name -> pname #101582

merged 1 commit into from Oct 25, 2020

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Oct 24, 2020

Motivation for this change

According to the manual, this is preferred for packages in Nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@omasanori
Copy link
Contributor

Result of nixpkgs-review pr 101582 1

3 packages built:
  • gparted
  • hdparm
  • tlp

omasanori
omasanori reviewed Oct 24, 2020
View reviewed changes
Copy link
Contributor

@omasanori omasanori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a small nit.

pkgs/os-specific/linux/hdparm/default.nix Show resolved Hide resolved
jonringer
jonringer approved these changes Oct 25, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 101582 1

3 packages built:
  • gparted
  • hdparm
  • tlp

@jonringer jonringer merged commit b8e5d13 into NixOS:master Oct 25, 2020
@Luflosi Luflosi deleted the hdparm-use-pname branch October 25, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omasanori omasanori omasanori approved these changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Luflosi @omasanori @jonringer