Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.scikit-fuzzy: init at unstable-2020-10-03 #100090

Merged
merged 1 commit into from Nov 28, 2020
Merged

python3Packages.scikit-fuzzy: init at unstable-2020-10-03 #100090

merged 1 commit into from Nov 28, 2020

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Oct 9, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [NA] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

I'm not the biggest fan of having many downstream packages of scikit. They usually release subtle breaking changes. The codebase surface is massive. And they've caused me several hours of looking into why certain bumps are breaking builds/tests.

@bcdarwin
Copy link
Member Author

bcdarwin commented Oct 9, 2020

I would like to add https://github.com/jcreinhold/intensity-normalization, which needs scikit-fuzzy, to all-packages.nix, but if more scikit packages aren't desirable then I can perhaps add these to an overlay instead ...? On the other hand, this package is fairly small, has few dependencies, and the tests run in a few seconds.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 100090 run on x86_64-linux 1

2 packages built:
  • python37Packages.scikit-fuzzy
  • python38Packages.scikit-fuzzy

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 100090 run on x86_64-darwin 1

2 packages built:
  • python37Packages.scikit-fuzzy
  • python38Packages.scikit-fuzzy

@SuperSandro2000 SuperSandro2000 merged commit 46cd14b into NixOS:master Nov 28, 2020
@bcdarwin bcdarwin deleted the python3-scikit-fuzzy branch November 30, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcdarwin @jonringer @SuperSandro2000