Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nixops check: Strip known formatting from systemctl #1413

Merged
merged 1 commit into from Nov 11, 2020
Merged

Fix nixops check: Strip known formatting from systemctl #1413

merged 1 commit into from Nov 11, 2020

Conversation

roberth
Copy link
Member

@roberth roberth commented Oct 9, 2020 •
edited

Makes nixops check work correctly for recent NixOSes (including exit status, hack for #451 etc)

I was getting

$ nixops check
+----------+--------+-----+-----------+----------+----------------+------------------------------------------+-------+
| Name     | Exists | Up  | Reachable | Disks OK | Load avg.      | Units                                    | Notes |
+----------+--------+-----+-----------+----------+----------------+------------------------------------------+-------+
| compute1 | Yes    | Yes | Yes       | N/A      | 0.00 0.02 0.09 |   sys-fs-fuse-connections.mount [failed] |       |
|          |        |     |           |          |                |   sys-kernel-config.mount [failed]       |       |
|          |        |     |           |          |                | ● tmp.mount [failed]                     |       |
+----------+--------+-----+-----------+----------+----------------+------------------------------------------+-------+
# ...
$ echo $?
16

@roberth roberth changed the title nixops check: Strip known formatting from systemctl Fix nixops check: Strip known formatting from systemctl Oct 9, 2020
@roberth
Copy link
Member Author

roberth commented Oct 30, 2020

@adisbladis could you have a look at this pr?

@grahamc grahamc merged commit 8de0987 into NixOS:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@roberth @grahamc