terraform-full: fix evaluation #100072
Merged
terraform-full: fix evaluation #100072
+19
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will be relying on the pname to figure out where to link the plugin.
zimbatm
changed the title
This was referenced Oct 9, 2020
timstott
reviewed
Oct 9, 2020
timstott
reviewed
Oct 9, 2020
timstott
reviewed
Oct 9, 2020
timstott
approved these changes
Oct 9, 2020
There was a problem hiding this comment.
Successfully tested with the setup below.
# main.tf
terraform {
required_providers {
acme = {
source = "getstackhead/acme"
version = "1.5.0-patched"
}
auth0 = {
source = "nixpkgs/auth0"
}
ansible = {
source = "nixpkgs/ansible"
}
}
}
# provider available on registry.terraform.io
provider "acme" {}
# custom providers
provider "ansible" {}
provider "auth0" {}
# hashicorp providers
provider "cloudinit" {}
provider "dns" {}rm -rf .terraform
nix-shell -I nixpkgs=$HOME/projects/nix/nixpkgs -p 'terraform_0_13.withPlugins (p : with p;[acme auth0 cloudinit dns ansible])' --command "terraform init"
Initializing provider plugins...
- Finding getstackhead/acme versions matching "1.5.0-patched"...
- Finding latest version of nixpkgs/auth0...
- Finding latest version of nixpkgs/ansible...
- Finding latest version of hashicorp/cloudinit...
- Finding latest version of hashicorp/dns...
- Installing nixpkgs/auth0 v0.11.0...
- Installed nixpkgs/auth0 v0.11.0 (unauthenticated)
- Installing nixpkgs/ansible v1.0.3...
- Installed nixpkgs/ansible v1.0.3 (unauthenticated)
- Installing hashicorp/cloudinit v1.0.0...
- Installed hashicorp/cloudinit v1.0.0 (unauthenticated)
- Installing hashicorp/dns v2.2.0...
- Installed hashicorp/dns v2.2.0 (unauthenticated)
- Installing getstackhead/acme v1.5.0-patched...
- Installed getstackhead/acme v1.5.0-patched (unauthenticated)
The following providers do not have any version constraints in configuration,
so the latest version was installed.
To prevent automatic upgrades to new major versions that may contain breaking
changes, we recommend adding version constraints in a required_providers block
in your configuration, with the constraint strings suggested below.
* hashicorp/cloudinit: version = "~> 1.0.0"
* hashicorp/dns: version = "~> 2.2.0"
* nixpkgs/ansible: version = "~> 1.0.3"
* nixpkgs/auth0: version = "~> 0.11.0"
Terraform has been successfully initialized!Move the providerSourceAddress fallback to the terraform.withPlugins function. Since plugins can be arbitrary derivations, there is no guarantee that this attribute will be exposed. While doing that I also cleaned the toDrv function to only pass attributes to the builder which are required by the build. The Terraform 0.13 fallback slug has changed from `nixpkgs/<provider-owner>/<provider-name>` to `nixpkgs/<provider-name>` as the owner is also not always available. As a nixpkgs user, all I know is that the provider is in nixpkgs and his name, the owner information is not necessarily easy to get by.
zimbatm
force-pushed
the
tf-0.13-fixups
branch
from
fe9b869 to
c79ff8d
Compare
ofborg
bot
added
10.rebuild-darwin: 0
|
@zimbatm Would it be an option to backport this to 20.09 release to be able to use terraform 0.13 in 20.09 ? I can cherry pick if you want |
|
Was the 0.13 initial work also ported to 20.09? Normally I would say no, as 20.09 should only get fixes at this point. |
|
The initial work is not in @jfroche you may want to acquire these changes through an overlay. |
|
@timstott Sure understand your point. We already use this wonderful commit (thank you !) within our overlay. But is that mean that terraform 0.13 is available in 20.09 but that we cannot use it with providers ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the nixpkgs evaluation that was broken by
cd1b594 (#99198)
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)