Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyhton3Packages.ibis-framework: fix tests for pandas 1.1 #100099

Merged
merged 1 commit into from Oct 9, 2020
Merged

pyhton3Packages.ibis-framework: fix tests for pandas 1.1 #100099

merged 1 commit into from Oct 9, 2020

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Oct 9, 2020 •
edited

Motivation for this change

Fix the build

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc #97479

@veprbl veprbl added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 9, 2020
@veprbl
Copy link
Member Author

veprbl commented Oct 9, 2020

@GrahamcOfBorg eval

@ofborg ofborg bot requested a review from costrouc October 9, 2020 20:28
@veprbl veprbl merged commit c42c904 into NixOS:master Oct 9, 2020
@veprbl veprbl deleted the pr/ibis-framework_fix branch October 9, 2020 20:45
veprbl added a commit that referenced this pull request Oct 9, 2020
@veprbl
pyhton3Packages.ibis-framework: fix tests for pandas 1.1
1cd0f2d 
(cherry picked from commit c9f7ef3)
cc #100099
@veprbl veprbl added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 9, 2020
@veprbl veprbl restored the pr/ibis-framework_fix branch December 1, 2020 16:46
@veprbl veprbl deleted the pr/ibis-framework_fix branch December 1, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@veprbl