Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onnxconverter-common: init at 1.7.0 #100093

Closed
wants to merge 3 commits into from
Closed

onnxconverter-common: init at 1.7.0 #100093

wants to merge 3 commits into from

Conversation

imalsogreg
Copy link
Contributor

Motivation for this change

Add onnxconverter-common, part of the python deep learning ecosystem.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip" (there are no downstream dependencies for this package yet)
  • Tested execution of all binary files (usually in ./result/bin/) (there are no binaries)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Oct 9, 2020
View reviewed changes
pkgs/development/python-modules/onnxconverter-common/default.nix
format = "wheel";
src = fetchPypi {
inherit pname version;
format = "wheel";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's preferable to not use wheels, do you mind fetching from github: https://github.com/microsoft/onnxconverter-common

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonringer It looks like pypi only provides a wheel: https://pypi.org/project/onnxconverter-common/1.7.0/#files
So are you suggesting that I fetchFromGitHub and build from source, rather than using fetchPypi?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonringer It looks like pypi only provides a wheel: pypi.org/project/onnxconverter-common/1.7.0/#files
So are you suggesting that I fetchFromGitHub and build from source, rather than using fetchPypi?

Yes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fetch from github.

pkgs/development/python-modules/onnxconverter-common/default.nix Outdated Show resolved Hide resolved
imalsogreg and others added 2 commits October 9, 2020 13:48
@imalsogreg @jonringer
Update pkgs/development/python-modules/onnxconverter-common/default.nix
579c1ff 
Co-authored-by: Jon <jonringer@users.noreply.github.com>
@imalsogreg @jonringer
Update pkgs/development/python-modules/onnxconverter-common/default.nix
1bb9261 
Co-authored-by: Jon <jonringer@users.noreply.github.com>
@jonringer
Copy link
Contributor

Please follow CONTRIBUTING.md and manual#submitting-changes-making-patches and squash the fix-up commits.

git rebase -i is a powerful command which achieves this, I created a small video demonstrating it's use here. A more indepth text tutorial can be found here

@stale
Copy link

stale bot commented Jul 19, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 19, 2021
@SuperSandro2000
Copy link
Member

Closing due to inactivity from author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@imalsogreg @jonringer @SuperSandro2000