Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oracleXE: remove #100088

Merged
merged 1 commit into from Oct 9, 2020
Merged

oracleXE: remove #100088

merged 1 commit into from Oct 9, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Oct 9, 2020

This is heavily outdated and unmaintained. If someone decides to pick it
up again, it can be reintroduced.

Closes #99649.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
oracleXE: remove
b1e6272 
This is heavily outdated and unmaintained. If someone decides to pick it
up again, it can be reintroduced.

Fixes NixOS#99649.
@flokli flokli mentioned this pull request Oct 9, 2020
Closed
@doronbehar
Copy link
Contributor

@GrahamcOfBorg eval

aanderse
aanderse approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☹️

@flokli flokli merged commit 7d8c02e into NixOS:master Oct 9, 2020
@flokli flokli deleted the remove-oracle-xe branch October 9, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aszlig aszlig aszlig approved these changes

@aanderse aanderse aanderse approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to find the oracle-xe default password for system admin ?
4 participants
@flokli @doronbehar @aszlig @aanderse