Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thunderbird, thunderbird-bin: 78.3.1 -> 78.3.2 #100079

Closed
wants to merge 2 commits into from
Closed

thunderbird, thunderbird-bin: 78.3.1 -> 78.3.2 #100079

wants to merge 2 commits into from

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Oct 9, 2020

Motivation for this change
  • Bug fixes and updates.

https://www.thunderbird.net/en-US/thunderbird/78.3.2/releasenotes/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar
Copy link
Contributor

@GrahamcOfBorg eval

@mweinelt
Copy link
Member

mweinelt commented Oct 9, 2020

Result of nixpkgs-review pr 100079 1

2 packages built:
  • thunderbird
  • thunderbird-bin

@mweinelt
Copy link
Member

mweinelt commented Oct 9, 2020 •
edited

Thunderbird has been crashing on me every once in a while on startup or later during usage, but that isn't directly related to this specific version. Anyway, it happend to me twice while starting the binary from the thunderbird package on wayland (sway).

[nix-shell:~/.cache/nixpkgs-review/pr-100079]$ ./results/thunderbird/bin/thunderbird 
[calBackendLoader] Using Thunderbird's libical backend
console.debug: "Successfully loaded OpenPGP library librnp.so from /nix/store/jnhnfnzszj1ygnaa8k030hfl41f95r1h-thunderbird-78.3.2/lib/thunderbird/librnp.so"
console.debug: "public keys: 29, secret keys: 2"
console.debug: "2 protected and 0 unprotected keys"
console.log: (new Error("Cannot load required OTR library", "resource:///modules/OTRLib.jsm", 75))
Gdk-Message: 01:00:44.429: Error 32 (Broken pipe) dispatching to Wayland display.

[nix-shell:~/.cache/nixpkgs-review/pr-100079]$ ./results/thunderbird/bin/thunderbird 
[calBackendLoader] Using Thunderbird's libical backend
console.debug: "Successfully loaded OpenPGP library librnp.so from /nix/store/jnhnfnzszj1ygnaa8k030hfl41f95r1h-thunderbird-78.3.2/lib/thunderbird/librnp.so"
console.debug: "public keys: 29, secret keys: 2"
console.debug: "2 protected and 0 unprotected keys"
console.log: (new Error("Cannot load required OTR library", "resource:///modules/OTRLib.jsm", 75))
console.error: Lightning: 
  [calCachedCalendar] replay action failed: <unknown>, uri=https://davical.darmstadt.ccc.de/public.php/foo/bar/, result=2147500037, operation=[xpconnect wrapped calIOperation]

(thunderbird:604): GLib-GIO-WARNING **: 01:01:02.956: Failed to execute child process “update-desktop-database” (No such file or directory)
Gdk-Message: 01:01:18.131: Error reading events from display: Broken pipe

I wonder if thunderbird should depend on desktop-file-utils. And then there is this odd error about being unable to load an OTR library.

The latter error does not appear on the thunderbird-bin package.

Once up both versions do work.

@vcunat vcunat changed the title thunderbird, thunderbird-bin: 78.2.2 -> 78.3.2 thunderbird, thunderbird-bin: 78.3.1 -> 78.3.2 Oct 10, 2020
@taku0
Copy link
Contributor Author

taku0 commented Oct 10, 2020 •
edited

I also get Cannot load required OTR library but it works fine with X.Org Server. It works fine with an exiting profile and a fresh profile.

@vcunat
Copy link
Member

vcunat commented Oct 10, 2020

I've never seen anyone using Thunderbird for chat, so perhaps OTR in there has been broken 🤷🏽

vcunat
vcunat approved these changes Oct 11, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used -bin for several minutes and the compiled one for about half a day.

vcunat added a commit that referenced this pull request Oct 11, 2020
@vcunat
Merge #100079: thunderbird-*: 78.3.1 -> 78.3.2
2d4225b
@mweinelt
Copy link
Member

mweinelt commented Oct 12, 2020 via email

@vcunat
Copy link
Member

vcunat commented Oct 12, 2020

👍🏽 I understood that this update doesn't seem to change those problems anyway.

@vcunat
Copy link
Member

vcunat commented Oct 14, 2020

Oops, I unintentionally merged the previous version with incorrect commit message.

@vcunat vcunat closed this Oct 14, 2020
This was referenced Oct 14, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@nbp nbp Awaiting requested review from nbp

@edolstra edolstra Awaiting requested review from edolstra

@lovesegfault lovesegfault Awaiting requested review from lovesegfault

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@taku0 @doronbehar @mweinelt @vcunat