New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quodlibet: 4.2.1 -> 4.3.0, fix tests #101266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog looks alright to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Would you like to take maintainer status? Frankly I have no clue how GTK works on Nix, and I no longer use NixOS or this package, so I should probably be dropped as a maintainer.
Result of 2 packages failed to build:- quodlibet-full - quodlibet-xine-full 3 packages built:- quodlibet - quodlibet-without-gst-plugins - quodlibet-xine |
|
Motivation for this change
Package doesn't build (due to failing tests) and is out of date.
Things done
I'm not very familiar with the application so I can't really test it very extensively but at least it builds and runs now.
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)