Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell-generic-builder: Add missing preHaddock and postHaddock arguments #101257

Merged
merged 1 commit into from Oct 22, 2020
Merged

haskell-generic-builder: Add missing preHaddock and postHaddock arguments #101257

merged 1 commit into from Oct 22, 2020

Conversation

expipiplus1
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cdepillabout
cdepillabout approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but could you rebase it on the haskell-updates branch? I'll merge it in after it has been rebased.

@expipiplus1
Copy link
Contributor Author

Done, thanks!

@ofborg ofborg bot requested review from offlinehacker and peti October 22, 2020 02:20
@cdepillabout cdepillabout changed the base branch from master to haskell-updates October 22, 2020 02:56
@cdepillabout
Copy link
Member

@GrahamcOfBorg build haskellPackages.lens

@cdepillabout
Copy link
Member

lens builds on x86_64, so this looks good to me. Thanks!

@cdepillabout cdepillabout merged commit 1f30ad1 into NixOS:haskell-updates Oct 22, 2020
@expipiplus1
Copy link
Contributor Author

expipiplus1 commented Oct 22, 2020 via email

@expipiplus1 expipiplus1 deleted the joe-postHaddock branch October 26, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout approved these changes

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: haskell 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@expipiplus1 @cdepillabout