Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] python38Packages.scrapy-fake-useragent: fix build #101275

Merged
merged 1 commit into from Oct 21, 2020
Merged

[20.09] python38Packages.scrapy-fake-useragent: fix build #101275

merged 1 commit into from Oct 21, 2020

Conversation

das-g
Copy link
Member

@das-g das-g commented Oct 21, 2020

backport to release-20.09 of 71e7f74, which entered master as part of PR #99513

Motivation for this change

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix run nixpkgs.nixpkgs- review -c nixpkgs-review wip -b release-20.09
  • Tested execution of all binary files (usually in ./result/bin/)
    • (there are none)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@das-g das-g changed the title python38Packages.scrapy-fake-useragent: fix build [20.09] python38Packages.scrapy-fake-useragent: fix build Oct 21, 2020
@das-g
Copy link
Member Author

das-g commented Oct 21, 2020

I've filed #101278 for the license change (on master). As soon as that's merged, I can include the change here, too.

@das-g
Copy link
Member Author

das-g commented Oct 21, 2020

Result of nixpkgs-review pr 101275 1

2 packages built:
  • python37Packages.scrapy-fake-useragent
  • python38Packages.scrapy-fake-useragent

jonringer
jonringer approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 101275 1

2 packages built:
  • python37Packages.scrapy-fake-useragent
  • python38Packages.scrapy-fake-useragent

@jonringer jonringer merged commit 3870956 into NixOS:release-20.09 Oct 21, 2020
@das-g das-g deleted the scrapy-fake-useragent branch October 21, 2020 20:19
@das-g
Copy link
Member Author

das-g commented Oct 21, 2020

I've filed #101278 for the license change (on master). As soon as that's merged, I can include the change here, too.

Oops, this PR here (#101275) got merged, before I got to cherry-pick 44465f6 from #101278 to it. Thus now as a separate PR: #101282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@das-g @jonringer @marsam