Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.sqlalchemy: 1.3.19 -> 1.3.20 #101295

Closed
wants to merge 1 commit into from
Closed

pythonPackages.sqlalchemy: 1.3.19 -> 1.3.20 #101295

wants to merge 1 commit into from

Conversation

nbke
Copy link
Contributor

@nbke nbke commented Oct 21, 2020

Motivation for this change

https://docs.sqlalchemy.org/en/13/changelog/changelog_13.html#change-1.3.20

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

r-burns
r-burns requested changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@r-burns r-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this should go into staging due to the number of rebuilds

@jonringer
Copy link
Contributor

if it was under 500, I would be fine with master as well. But yea, better just target staging

git rebase --onto=origin/staging HEAD^
git push ... ... --force

then you need to edit the target branch on this PR

@nbke nbke changed the base branch from master to staging October 22, 2020 08:47
@nbke nbke closed this Oct 22, 2020
@nbke nbke reopened this Oct 22, 2020
@FRidh
Copy link
Member

FRidh commented Oct 25, 2020

Included in #101636.

@FRidh FRidh closed this Oct 25, 2020
@nbke nbke deleted the update-sqlalchemy branch October 25, 2020 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-burns r-burns r-burns requested changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@alyssais alyssais Awaiting requested review from alyssais

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@LnL7 LnL7 Awaiting requested review from LnL7

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@Mic92 Mic92 Awaiting requested review from Mic92

@zowoq zowoq Awaiting requested review from zowoq

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+ 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nbke @jonringer @FRidh @r-burns @Janik-Haag