nix develop --phase: chdir to flake directory #4176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I marked this as stale due to inactivity. → More info |
thufschmitt
reviewed
Jul 15, 2021
mkenigs
force-pushed
the
fix-3976
branch
3 times, most recently
from
3904e28
to
ba6ad37
Compare
For git+file and path flakes, chdir to flake directory so that phases that expect to be in the flake directory can run Fixes NixOS#3976
|
@regnat this look good now? |
|
@mkenigs Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For git+file and path flakes, chdir to flake directory so that phases
that expect to be in the flake directory can run
Fixes #3976
Personally I feel like this is kind of hacky to make exceptions for just git+file and path flakes, which is part of why I think what develop does should be clarified (#4170) But it is convenient for this to work