@luxferresum can you try/review?
@ckauhaus can you also put the securiy tag here?

/marvin opt-in
/status needs_reviewer

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

BTW you should consider adding yourself as a maintainer 😉. You can just send that PR directly to me.

@wamserma Hi, thanks for the awesome contribution of bringing JabRef up to 5.1! I just thought I'd mention that I've found that if I use this then opening external files (e.g. attaching a PDF to an entry an opening it, or opening any clickable URL in JabRef) does not work (I'm on NixOS 20.09). With errors such as java.io.IOException: Cannot run program "xdg-open": error=2, No such file or directory. I have found a workaround which is to use @tyrion's approach (using the .deb) mentioned here #86331 (comment) - changing it to 5.1 (and the hash of course) works fine. I'm not sure how easy/hard fixing that issue with 5.1 in nixpkgs would be but just thought I'd mention it. I'm happily using @tyrion's approach for now 🙂

@Coda-Coda Thanks for reporting. I can reproduce this, when running from a pure nix-shell. The reason seems xdg-utils is missing from the runtime deps. I'll pick this up and bump to 5.2.

Could it be backported to NixOS 20.09?

@alexeymuranov No, as this is not perfectly working (see discussion above and in #112028). It will be in 21.05, though.