Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] python3Packages.scrapy-fake-useragent: fix license #101282

Merged
merged 1 commit into from Oct 21, 2020
Merged

[20.09] python3Packages.scrapy-fake-useragent: fix license #101282

merged 1 commit into from Oct 21, 2020

Conversation

das-g
Copy link
Member

@das-g das-g commented Oct 21, 2020

(cherry picked from commit 44465f6)

Motivation for this change

backport of PR #101278

Upstream changed to MIT with alecxe/scrapy-fake-useragent@0ea7614 (so with Version 1.4.0, it seems), but looks like it got overlooked in b5d6f77, which entered master (before branch-off of release-20.09) as part of PR #95609.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
    • meta.description is capitalized
    • meta.description doesn't start with the package name
    • meta.description doesn't have a period at the end
    • meta.license is set and fits the upstream license
    • meta.maintainers is set

@das-g
python3Packages.scrapy-fake-useragent: fix license
f4e4e97 
which upstream changed to MIT with alecxe/scrapy-fake-useragent@0ea7614

(cherry picked from commit 44465f6)
@das-g
Copy link
Member Author

das-g commented Oct 21, 2020

Result of nixpkgs-review pr 101282 1

@das-g das-g mentioned this pull request Oct 21, 2020
Merged
10 tasks
@jonringer jonringer merged commit 9e627ad into NixOS:release-20.09 Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@das-g @jonringer