Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/mosquitto: add passwordFile and hashedPasswordFile options #101261

Merged
merged 1 commit into from Oct 25, 2020

Conversation

felschr
Copy link
Member

@felschr felschr commented Oct 21, 2020

Motivation for this change

Making it possible to specify mosquitto user passwords (or hashed passwords) by referencing a file.
See #24288.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@felschr felschr force-pushed the feat/mosquitto-password-file branch from c477217 to 30b1d77 Compare October 21, 2020 17:15
@felschr felschr marked this pull request as ready for review October 21, 2020 17:49
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/347

@bjornfor bjornfor merged commit 542f750 into NixOS:master Oct 25, 2020
@bjornfor
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants