redshift-plasma-applet: update patchPhase to fix manual updates, don't use upstream #101279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to patch every 'redshift' to ${redshift }/bin/redshift so
Nix can use the right binary
-P Reset existing gamma ramps before applying new color effect.
Add '-P' flag to redshiftOneTimeCommand because it doesn't
work on NixOS if it's not there (?). I'm not sure how it works
on Ubuntu like it is.
I tested this with a local override, and it works on kde.
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
|
Found a better way to do this, closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to patch every
redshiftto${redshift }/bin/redshiftsoNix can use the right binary. Current patch misses one.
Upstream applied https://invent.kde.org/plasma/plasma-redshift-control/-/commit/898c3a4cfc6c317915f1e664078d8606497c4049 to add
-Pto onetime color settings on redshift version >= 1.12Since nixpkgs uses 1.12, and upstream seems to break manually toggling the applet off, I applied this fix inline in the patches, and took note of it.
I tested this with a local override, and it works on NixOS+KDE
Motivation for this change
Issue #83250 has been a large blocker from me using NixOS more. I finally dove into fix it.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)