Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R: 4.0.2 -> 4.0.3 #100393

Merged
merged 1 commit into from Oct 25, 2020
Merged

R: 4.0.2 -> 4.0.3 #100393

merged 1 commit into from Oct 25, 2020

Conversation

matthiasbeyer
Copy link
Contributor

@matthiasbeyer matthiasbeyer commented Oct 13, 2020 •
edited

Build pending on my server... Will update as soon as it succeeded.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthiasbeyer
R: 4.0.2 -> 4.0.3
ea4a13e 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@ofborg ofborg bot requested review from timokau and peti October 13, 2020 08:20
@matthiasbeyer matthiasbeyer marked this pull request as ready for review October 13, 2020 08:51
@lblasc
Copy link
Contributor

lblasc commented Oct 14, 2020

Looks good. It would be great to merge it together with #93590

@matthiasbeyer
Copy link
Contributor Author

Can this be merged?

@peti peti merged commit 40bc6c8 into NixOS:master Oct 25, 2020
@matthiasbeyer matthiasbeyer deleted the update-r branch October 26, 2020 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau Awaiting requested review from timokau

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthiasbeyer @lblasc @peti