Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libayatana-appindicator: 0.5.4 -> 0.5.5, generate typelibs for gobject-introspection #100411

Merged
merged 1 commit into from Oct 14, 2020
Merged

libayatana-appindicator: 0.5.4 -> 0.5.5, generate typelibs for gobject-introspection #100411

merged 1 commit into from Oct 14, 2020

Conversation

NickHu
Copy link
Contributor

@NickHu NickHu commented Oct 13, 2020 •
edited

Motivation for this change

This change makes it so that lines like

from gi.repository import AyatanaAppIndicator3

in Python code works, by making sure the typelib is generated (see
https://github.com/AyatanaIndicators/libayatana-appindicator/blob/master/configure.ac#L80).

I also bumped the versions, and fixed some metadata that was incorrect.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@NickHu
libayatana-appindicator: 0.5.4 -> 0.5.5, generate typelibs for gobjec…
f0cd405 
…t-introspection

libayatana-indicator: 0.6.3 -> 0.8.2
@NickHu NickHu changed the title libayatana-appindicator: generate typelibs for gobject-introspection libayatana-appindicator: 0.5.4 -> 0.5.5, generate typelibs for gobject-introspection Oct 13, 2020
@garbas garbas merged commit 9f41506 into NixOS:master Oct 14, 2020
@NickHu NickHu deleted the ayatana branch October 14, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NickHu @garbas