Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport to 20.09 : kubernetes-helm: 3.3.1 -> 3.3.4 #100375

Merged
merged 1 commit into from Oct 13, 2020
Merged

Backport to 20.09 : kubernetes-helm: 3.3.1 -> 3.3.4 #100375

merged 1 commit into from Oct 13, 2020

Conversation

Chili-Man
Copy link
Contributor

Motivation for this change

Addresses #99786

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Chili-Man Chili-Man changed the title kubernetes-helm: 3.3.1 -> 3.3.4 Backport to 20.09 : kubernetes-helm: 3.3.1 -> 3.3.4 Oct 13, 2020
@Chili-Man Chili-Man mentioned this pull request Oct 13, 2020
Closed
4 tasks
@zowoq
Copy link
Contributor

zowoq commented Oct 13, 2020

https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes

Please use git cherry-pick -x.

@Chili-Man
kubernetes-helm: 3.3.1 -> 3.3.4
613491e 
(cherry picked from commit 53fcb50)
@Chili-Man
Copy link
Contributor Author

@zowoq updated to use cherry-pick -x

@zowoq zowoq merged commit 36d7be8 into NixOS:release-20.09 Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frostman Frostman Awaiting requested review from Frostman

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

@kalbasit kalbasit Awaiting requested review from kalbasit

@edude03 edude03 Awaiting requested review from edude03

@rlupton20 rlupton20 Awaiting requested review from rlupton20

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Chili-Man @zowoq