Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

julia-mono: 0.018 -> 0.022 #100386

Closed
wants to merge 4 commits into from
Closed

julia-mono: 0.018 -> 0.022 #100386

wants to merge 4 commits into from

Conversation

toastal
Copy link
Contributor

@toastal toastal commented Oct 13, 2020 •
edited

Motivation for this change

Update to latest. Also mkdir -p on the truetype folder as well.

https://github.com/cormullion/juliamono/releases/tag/v0.021

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from suhr October 13, 2020 06:56
@toastal toastal changed the title julia-mono: 0.018 -> 0.020 julia-mono: 0.018 -> 0.021 Oct 15, 2020
@ofborg ofborg bot requested a review from suhr October 15, 2020 09:09
@toastal toastal changed the title julia-mono: 0.018 -> 0.021 julia-mono: 0.018 -> 0.022 Oct 19, 2020
@suhr
Copy link
Contributor

suhr commented Oct 19, 2020

@toastal Can you rebase your branch, so there would be only a single commit?

@ofborg ofborg bot requested a review from suhr October 19, 2020 07:31
@toastal
Copy link
Contributor Author

toastal commented Oct 19, 2020 •
edited

@suhr Isn't a squash merge good enough? I already did some merges in from master and I'm afraid a rebase could cause issues.

@suhr suhr mentioned this pull request Oct 19, 2020
Merged
10 tasks
@suhr
Copy link
Contributor

suhr commented Oct 19, 2020

I rebased your branch into an another PR: #101062.

@garbas garbas closed this Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suhr suhr Awaiting requested review from suhr

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@toastal @suhr @garbas