New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openjdk: add openjdk15 #100403
openjdk: add openjdk15 #100403
Conversation
Quick test:
Sample code: https://github.com/taku0/JavaSample/tree/4086d84efd8041d09f0075a9f7c6fe936553c130 |
MediaPlayer doesn't work even with |
ping |
(incomplete)
ok, so no regression there
who are you pinging? Rebased, ofborg seems happier now as well. Note there has been some discussion around which Java versions to retire, see https://discourse.nixos.org/t/retirement-of-old-openjdk-releases/9929 |
I've looked this over somewhat, but haven't had time to try it locally. Still trying to find that time. :) The only thing I noticed so far is: I don't think we ought to leave both jdk14 and jdk15 "exposed" in |
If we need to build it to bootstrap openjdk15 anyway, what is the advantage of not exposing it in |
I'm not sure we want to maintain the approach of building an ever-growing chain of bootstrap jdks. It might make more sense to e.g. bootstrap with adoptopenjdk. It's also the case that any explicit dependencies on Maybe I'm just being optimistic that serious breaking changes like JPMS will be few and far between ... :) |
That is what we do, right? (except on i686 where adoptopenjdk is not available, according to the comment)
I would like to remove them - that was part of my motivation for #105924: if we can use that to easily fetch various JDK's for development purposes, dropping openjdk14 from the 'real' packages would not be a big deal anymore. |
It's not what's done in this PR; it just does:
|
Ah, you're quite right, I was looking at the wrong one. Anyway, I see adoptopenjdk 15 has made it into nixpkgs since, which is sufficient for my use case so I'll close this one. |
I've resurrected this work in #107547. |
Motivation for this change
To have the latest JDK version available.
Support for darwin (of for 32-bit systems) is not included in this PR, but it seems useful already.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)