Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clipcat: init at 0.4.19 #100638

Merged
merged 1 commit into from
Oct 29, 2020
Merged

clipcat: init at 0.4.19 #100638

merged 1 commit into from
Oct 29, 2020
+66 −0

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Oct 15, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@xrelkd
clipcat: init at 0.4.19

Verified

This commit was signed with the committer’s verified signature. The key has expired.
cole-h Cole Helbling
GPG key ID: B37E0F2371016A4C
Expired
Verified
Learn about vigilant mode
7ee6eb7
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 15, 2020
@xrelkd
Copy link
Contributor Author

xrelkd commented Oct 18, 2020

Hi @marsam, Could you review this PR? Thank you!!

@marsam
Copy link
Contributor

marsam commented Oct 29, 2020

Sorry for the delay. LGTM

@marsam marsam merged commit 8305cce into NixOS:master Oct 29, 2020
@xrelkd
Copy link
Contributor Author

xrelkd commented Oct 29, 2020

@marsam Thank you very much!!

@xrelkd xrelkd deleted the add/clipcat branch October 29, 2020 04:06
@xrelkd xrelkd mentioned this pull request Oct 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xrelkd @marsam