nixos/matomo: point path.geoip2 outside of the nix store. #100617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlivierMarty
force-pushed
the
matomo
branch
3 times, most recently
from
fb2e35d
to
eb28ca2
Compare
OlivierMarty
changed the title
sorki
approved these changes
Dec 29, 2020
1000101
reviewed
Feb 10, 2021
10 tasks
path.geoip2 pointed to the nix store which is read-only. Matomo was failing to download a geoip2 database. See NixOS#64759.
|
@Kiwi @florianjacob could you maybe take a look? Thank you! |
ThibautMarty
approved these changes
Jun 16, 2021
There was a problem hiding this comment.
LGTM
This is needed when setting up geolocation from the UI, but also if one downloads GeoIP2 databases in /var/lib/matomo/misc (I do that with a custom systemd service but #121145 can certainly work too now).
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
|
LGTM. If noone objects, let's merge this in a few days. |
13 tasks
|
Thank you! |
sorki
added a commit
to fix-all-the-things/om-ops
that referenced
this pull request
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
path.geoip2 pointed to the nix store which is read only. Matomo fails to
download geoip database. See #64759.
Motivation for this change
By default matomo config path.geoip2 points to the nix store. One can setup geolocalisation from the UI, but the download would fail because the nix store is read-only. See #64759.
This PR changes the path to point to the matomo state directory, allowing one to enable the matomo service and then configure the geolocalisation from the matomo UI without pain.
Note that there are already some efforts to build a geoip database (e.g. #73767), but matomo can also handle it for simpler set-ups.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)