New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python37Packages.py4j: 0.10.9 -> 0.10.9.1 #100623
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
requested changes
Oct 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pyspark needs to be update:
ERROR: Could not find a version that satisfies the requirement py4j==0.10.9 (from pyspark==3.0.0) (from versions: none)
ERROR: No matching distribution found for py4j==0.10.9 (from pyspark==3.0.0)
https://github.com/NixOS/nixpkgs/pull/100623
3 packages marked as broken and skipped:
python27Packages.databricks-connect python37Packages.databricks-connect python38Packages.databricks-connect
3 packages failed to build:
python27Packages.pyspark python37Packages.pyspark python38Packages.pyspark
6 packages built:
python27Packages.py4j python27Packages.python-ldap-test python37Packages.py4j python37Packages.python-ldap-test python38Packages.py4j python38Packages.python-ldap-test
jskrzypek
added a commit
to jskrzypek/nixpkgs
that referenced
this pull request
Nov 23, 2020
Pyspark switched to pinning py4j==0.10.9 with v3.0.0 - see this commit: https://github.com/apache/spark/\ commit/fc4e56a54c15e20baf085e6061d3d83f5ce1185d This meant that since the bump to pyspark v3.0.0 - in this commit: https://github.com/NixOS/nixpkgs/\ commit/5181547ae6624b462919a806c4d0888e6e4630f4 - the patch was no longer matching on the 'py4j==0.10.7' string that was working previously. The failing patch went unnoticed previously because the version of py4j pinned by pyspark>=3.0.0 was the same as the py4j provided by nixpkgs. However, a recent PR (NixOS#101636) bumped the version of py4j to 0.10.9.1 in this commit: https://github.com/NixOS/nixpkgs/\ commit/43a91282d66223c5cb978d53fbe1033f56dd7f2b which caused the version pinned by pyspark to no longer match the version provided by nixpkgs. FWIW, @jonringer flagged this issue on another PR that tried to bump py4j: NixOS#100623. My solution here was to upgrade the patch's target string to match the version found in pyspark's current setup.py.
10 tasks
jonringer
pushed a commit
that referenced
this pull request
Nov 24, 2020
Pyspark switched to pinning py4j==0.10.9 with v3.0.0 - see this commit: https://github.com/apache/spark/\ commit/fc4e56a54c15e20baf085e6061d3d83f5ce1185d This meant that since the bump to pyspark v3.0.0 - in this commit: https://github.com/NixOS/nixpkgs/\ commit/5181547ae6624b462919a806c4d0888e6e4630f4 - the patch was no longer matching on the 'py4j==0.10.7' string that was working previously. The failing patch went unnoticed previously because the version of py4j pinned by pyspark>=3.0.0 was the same as the py4j provided by nixpkgs. However, a recent PR (#101636) bumped the version of py4j to 0.10.9.1 in this commit: https://github.com/NixOS/nixpkgs/\ commit/43a91282d66223c5cb978d53fbe1033f56dd7f2b which caused the version pinned by pyspark to no longer match the version provided by nixpkgs. FWIW, @jonringer flagged this issue on another PR that tried to bump py4j: #100623. My solution here was to upgrade the patch's target string to match the version found in pyspark's current setup.py.
Result of 3 packages failed to build:
9 packages built:
|
py4j is on version 0.10.9.1 on master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python37Packages.py4j is: "Py4J enables Python programs running in a Python interpreter to dynamically access Java objects in a Java Virtual Machine. Methods are called as if the Java objects resided in the Python interpreter and Java collections can be accessed through standard Python collection methods. Py4J also enables Java programs to call back Python objects."
meta.homepage for python37Packages.py4j is: "https://www.py4j.org/"
meta.changelog for python37Packages.py4j is: ""
Updates performed
To inspect upstream changes
Impact
Checks done (click to expand)
built on NixOS
Warning: a test defined in
passthru.tests
did not pass0 of 0 passed binary check by having a zero exit code.
0 of 0 passed binary check by having the new version present in output.
found 0.10.9.1 with grep in /nix/store/rhp1yg22rgdm2ffr73il971fhbprizdx-python3.7-py4j-0.10.9.1
directory tree listing: https://gist.github.com/354870703ec38d3282eb19115833a9eb
du listing: https://gist.github.com/d5e06e6161892ee152f22c27e8a72ca4
Rebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-users
list or you can usesudo
since root is effectively trusted.Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of
nixpkgs-review
16 packages failed to build:
6 packages built:
Maintainer pings
cc @shlevy for testing.