New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.pynacl: 1.3.0 -> 1.4.0 #100646
Conversation
be0107d
to
fb80676
Compare
|
||
src = fetchPypi { | ||
inherit version; | ||
pname = "PyNaCl"; | ||
sha256 = "0c6100edd16fefd1557da078c7a31e7b7d7a52ce39fdca2bec29d4f7b6e7600c"; | ||
sha256 = "01b56hxrbif3hx8l6rwz5kljrgvlbj7shmmd2rjh0hn7974a5sal"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the correct sha256? According to https://pypi.org/project/PyNaCl/1.4.0/ it should be 54e9a2c849c742006516ad56a88f5c74bf2ce92c9f67435187c3c5953b346505
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's the same "sha", just expressed in a different base:
$ nix-hash --to-base16 --type sha256 01b56hxrbif3hx8l6rwz5kljrgvlbj7shmmd2rjh0hn7974a5sal
54e9a2c849c742006516ad56a88f5c74bf2ce92c9f67435187c3c5953b346505
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, TIL, just read the relevant section in the nixpkgs manual now 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you 👍
|
none of the failures look related to pynacl
|
I am not sure why the build fails with this error on one of my machine and if it is related to this PR. If it is unrelated I am going to open an issue.
|
I'm not able to repro it, but if it is flakey, we can disable it |
Motivation for this change
ordinary bump
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)