Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(vscodium|vscode): add automated aarch64-linux support #100641

Closed
wants to merge 4 commits into from
Closed

(vscodium|vscode): add automated aarch64-linux support #100641

wants to merge 4 commits into from

Conversation

colemickens
Copy link
Member

@colemickens colemickens commented Oct 15, 2020 •
edited

Motivation for this change
  • add aarch64-linux as a supported platform for vscodium
  • add aarch64-linux as a supported platform for vscode
  • add support for auto-updating both
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Synthetica9 October 15, 2020 20:34
@zakame
Copy link
Member

zakame commented Oct 16, 2020

Does this supersede #100586?

@samuela
Copy link
Member

samuela commented Oct 16, 2020

Does this supersede #100586?

Yes, I believe so. The hashes match.

samuela
samuela approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@samuela samuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

do you have any sense what would be required to do the same for vscode? it would be great to have that done as well!

@Synthetica9
Copy link
Member

LGTM

do you have any sense what would be required to do the same for vscode? it would be great to have that done as well!

Microsoft recently started providing binaries for aarch64, so it should be a similar level of effort.

@samuela
Copy link
Member

samuela commented Oct 16, 2020

The vscodium update to 1.50.1 is conflicting now that #98088 has landed I think.

@colemickens
Copy link
Member Author

I'll try to add VSCode aarch64 support and rebase this. Hopefully today.

@colemickens colemickens force-pushed the vscodium-aarch64 branch 2 times, most recently from 0222221 to b2fe876 Compare October 17, 2020 23:19
@colemickens colemickens changed the title vscodium: add automated aarch64-linux support (and update vscodium to 1.50.1) (vscodium|vscode): add automated aarch64-linux support Oct 17, 2020
@colemickens
Copy link
Member Author

I attempted the change. Due to where nixos-unstable is, it's not perfectly easy for me to test the VSCode addition e2e, but I suspect it works.

@colemickens colemickens force-pushed the vscodium-aarch64 branch 2 times, most recently from ff181ca to 5c498bd Compare November 20, 2020 01:09
@colemickens colemickens force-pushed the vscodium-aarch64 branch 2 times, most recently from 22aae49 to 8fbc86e Compare November 22, 2020 23:59
@colemickens
Copy link
Member Author 


[colemickens@aarch64:~/nixpkgs]$ nixpkgs-review pr 100641
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/100641/head:refs/nixpkgs-review/1
remote: Enumerating objects: 7, done.
remote: Counting objects: 100% (7/7), done.
remote: Total 7 (delta 6), reused 7 (delta 6), pack-reused 0
Unpacking objects: 100% (7/7), 1.32 KiB | 338.00 KiB/s, done.
From https://github.com/NixOS/nixpkgs
 + 22aae49f10a...8fbc86e9b3f refs/pull/100641/head -> refs/nixpkgs-review/1  (forced update)
$ git worktree add /home/colemickens/.cache/nixpkgs-review/pr-100641-1/nixpkgs e80b5cdf7a28f55a600643eeb58696c0727d833d
Preparing worktree (detached HEAD e80b5cdf7a2)
Updating files: 100% (23271/23271), done.
HEAD is now at e80b5cdf7a2 Merge pull request #104618 from sevenfourk/patch-3
$ nix-env -f /home/colemickens/.cache/nixpkgs-review/pr-100641-1/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit 8fbc86e9b3ff5e5a08a6ef85c04483b4fa054492
Automatic merge went well; stopped before committing as requested
$ nix-env -f /home/colemickens/.cache/nixpkgs-review/pr-100641-1/nixpkgs -qaP --xml --out-path --show-trace --meta
3 packages added:
vscode (init at 1.51.1) vscode-with-extensions (init at 1.51.1) vscodium (init at 1.51.1)

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/colemickens/.cache/nixpkgs-review/pr-100641-1/build.nix
[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/100641
3 packages built:
vscode vscode-with-extensions vscodium

[0.0 MiB DL]
$ nix-shell /home/colemickens/.cache/nixpkgs-review/pr-100641-1/shell.nix

[nix-shell:~/.cache/nixpkgs-review/pr-100641-1]$ exit
exit
$ git worktree prune

[colemickens@aarch64:~/nixpkgs]$

@ofborg ofborg bot requested a review from eadwu November 23, 2020 00:09
@colemickens colemickens mentioned this pull request Dec 27, 2020
Merged
10 tasks
@Mic92
Copy link
Member

Mic92 commented Dec 27, 2020

superseeded by #107052

@Mic92 Mic92 closed this Dec 27, 2020
@colemickens colemickens deleted the vscodium-aarch64 branch December 30, 2022 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuela samuela samuela approved these changes

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

@eadwu eadwu Awaiting requested review from eadwu

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@colemickens @zakame @samuela @Synthetica9 @Mic92