Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

networkmanager-sstp: init at unstable-2020-04-20, bump sstp from 1.0.12 to 1.0.13 #100657

Merged
merged 3 commits into from Oct 20, 2020
Merged

networkmanager-sstp: init at unstable-2020-04-20, bump sstp from 1.0.12 to 1.0.13 #100657

merged 3 commits into from Oct 20, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Oct 15, 2020 •
edited

Motivation for this change

Connecting to SSTP VPNs without manually working with sstpc.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

lovesegfault
lovesegfault approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@lovesegfault lovesegfault left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor nit.

I wish this was made optional, but perhaps that has to happen whenever we make all of NM's plugins optional

c.f. #84433

pkgs/tools/networking/network-manager/sstp/default.nix Outdated
Comment on lines 1 to 2
{ stdenv, fetchFromGitHub, substituteAll, autoreconfHook, sstp, ppp, file, intltool, pkgconfig, networkmanager, libsecret, gtk3
, withGnome ? true, gnome3, fetchpatch, libnma, glib }:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wish this was split over a few lines

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit adressed.

@flokli
Copy link
Contributor Author

flokli commented Oct 20, 2020

Okay, let's get this in, and work on making it optional in #84433, together with all the other plugins.

@flokli flokli merged commit 6e5ccaa into NixOS:master Oct 20, 2020
@flokli flokli deleted the network-manager-sstp branch October 20, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovesegfault lovesegfault lovesegfault approved these changes

@Phreedom Phreedom Awaiting requested review from Phreedom

@domenkozar domenkozar Awaiting requested review from domenkozar

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@obadz obadz Awaiting requested review from obadz

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @lovesegfault