Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.FutureAsyncAwait: init at 0.44 #100652

Merged
merged 2 commits into from Oct 16, 2020
Merged

perlPackages.FutureAsyncAwait: init at 0.44 #100652

merged 2 commits into from Oct 16, 2020

Conversation

zakame
Copy link
Member

@zakame zakame commented Oct 15, 2020 •
edited

Motivation for this change

This adds async/await keywords to Perl to enhance the use of Future-using code.

This also adds XS::Parse::Sublike as a dependency of this package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zakame zakame requested a review from stigtsp as a code owner October 15, 2020 22:25
stigtsp
stigtsp requested changes Oct 16, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zakame, welcome to the NixOS project 🎉

To make it build on darwin, can you add the following to both derivations?

perlPreHook = stdenv.lib.optionalString stdenv.isDarwin "export LD=$CC";

@zakame
Copy link
Member Author

zakame commented Oct 16, 2020

Thanks @stigtsp! Added that perlPreHook. Let me know if there's anything else to check on 💪

@stigtsp
Copy link
Member

stigtsp commented Oct 16, 2020

Thanks @stigtsp! Added that perlPreHook. Let me know if there's anything else to check on muscle

Can you add the changes to the perlPackages.FutureAsyncAwait: init at 0.44 commit instead?

@zakame zakame force-pushed the zakame/contrib/perl-FutureAsyncAwait branch from 35a29ba to b69b3f3 Compare October 16, 2020 12:46
@zakame
Copy link
Member Author

zakame commented Oct 16, 2020

@stigtsp sure, done.

@zakame
perlPackages.FutureAsyncAwait: init at 0.44
86e486a 
dependencies:
perlPackages.XSParseSublike: init at 0.10
@zakame zakame force-pushed the zakame/contrib/perl-FutureAsyncAwait branch from b69b3f3 to 86e486a Compare October 16, 2020 12:55
@stigtsp
Copy link
Member

stigtsp commented Oct 16, 2020

@GrahamcOfBorg build perlPackages.FutureAsyncAwait perldevelPackages.FutureAsyncAwait

stigtsp
stigtsp approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the contributions

Built and tested OK on darwin x64 and linux x64

Result of nixpkgs-review pr 100652 1

4 packages built:
  • perl530Packages.FutureAsyncAwait
  • perl530Packages.XSParseSublike
  • perl532Packages.FutureAsyncAwait
  • perl532Packages.XSParseSublike

@stigtsp stigtsp merged commit d944d67 into NixOS:master Oct 16, 2020
@zakame
Copy link
Member Author

zakame commented Oct 16, 2020

Thanks @stigtsp also for the guidance! 👍

@zakame zakame deleted the zakame/contrib/perl-FutureAsyncAwait branch October 16, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zakame @stigtsp @Janik-Haag