-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
marker: init at 2020.04.04 #100653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
marker: init at 2020.04.04 #100653
Conversation
/marvin opt-in |
Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here. |
Result of 1 package built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passes nixpkgs-review on non-nixos linux
Reminder: Please review! This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good bot :)
Since upstream hasn't responded I won't try to hold up this PR any longer. I think the most likely explanation is they intended to use LGPL3+ but accidentally copied the GPL license file. So for now I'll say LGTM 👍
/status needs_merger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @r-burns :)
Would it be possible to backport it to 20.09? I can try when i have some spare time... |
I'm not sure what the policy on backporting new packages is. You can mix packages from different channels though (see this discourse thread), so you could still install this on a 20.09 setup. Is that good enough for you? |
@timokau , it would be easier for me to use everything from one channel, i am not a very advanced user. According to this old message of Vladimír Čunát about stabilising NixOS 18.03, backporting new pacakges seems ok:
|
The most recent maintainers wiki entry says we should probably hold off on backporting the package. Adding a new channel to nix-env install packages is super easy, though:
And that should do it. You don't even need to be root. |
@trepetti, this didn't work for me: $ nix-channel --add https://nixos.org/channels/nixpkgs-unstable unstable
$ nix-env -iA unstable.marker
error: attribute 'unstable' in selection path 'unstable.marker' not found |
Then try |
@trepetti, yes it was |
@trepetti, the problem with having two channels for me is that now i cannot check for upgraded packages in the stable channel with $ nix-env -u --dry-run -- it shows everything from the unstable too. |
If you are on NixOS, you can have nix-env only upgrade packages using derivations from the default (stable) channel by providing that channel's file:
|
@trepetti , thanks. I am on NixOS indeed. |
That's a good find! Its a little old to base a decision on though. The current guidelines that @alexeymuranov linked don't give any concrete guidance (at least the way I read them). I asked on IRC, but unfortunately didn't get a reply. @jonringer do you have an opinion on backporting new packages? |
I'm okay with it philosophically. But would prefer people to use unstable when they want the latest of something. |
@jonringer, in my case i do not want the latest, i want any. |
Motivation for this change
Add Marker, a GTK3-based markdown editor for Linux desktops.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)