Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

itk: remove -march=corei7 and -mtune=native flags from cmake build files #100659

Merged
merged 1 commit into from Oct 16, 2020
Merged

itk: remove -march=corei7 and -mtune=native flags from cmake build files #100659

merged 1 commit into from Oct 16, 2020

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Oct 15, 2020 •
edited

  • probable cause of build failure on Hydra on branch release-20.09

for ZHF (#97479).

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bcdarwin
itk: remove -march=corei7 and -mtune=native flags from cmake build files
83a1ce3 
- probable cause of build failure on Hydra on branch release-20.09
@ofborg ofborg bot requested a review from viric October 15, 2020 23:27
jonringer
jonringer approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/NixOS/nixpkgs/pull/100659
3 packages built:
elastix itk simpleitk

risicle
risicle reviewed Oct 16, 2020
View reviewed changes
pkgs/development/libraries/itk/default.nix
substituteInPlace CMake/ITKSetStandardCompilerFlags.cmake \
--replace "-march=corei7" "" \
--replace "-mtune=native" ""
'';
Copy link
Contributor

@risicle risicle Oct 16, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely we need to restrict this to x86_64? ignore me

@risicle
Copy link
Contributor

risicle commented Oct 16, 2020

WFM macos 10.14. Reverse dependency elastix already broken for darwin.

@risicle risicle merged commit bdb7c69 into NixOS:master Oct 16, 2020
@bcdarwin bcdarwin deleted the fix-itk-flags branch October 16, 2020 20:20
@bcdarwin bcdarwin mentioned this pull request Oct 16, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risicle risicle risicle left review comments

@jonringer jonringer jonringer approved these changes

@viric viric Awaiting requested review from viric

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcdarwin @risicle @jonringer