Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bash: 5.0p17 -> 5.0p18 #100662

Merged
merged 2 commits into from Oct 16, 2020
Merged

bash: 5.0p17 -> 5.0p18 #100662

merged 2 commits into from Oct 16, 2020

Conversation

NeQuissimus
Copy link
Member

Motivation for this change

Update, fix update script

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@NeQuissimus
bash: Use nix-shell in update script
d63ddac 
The script assumed that `wget` was available in the environment
along with common CA certificates.
Replaced the detection of GPG, which is not necessary anymore.
Added pulling the public key bash releases and patches are signed with,
without which we cannot verify signatures.
@NeQuissimus
bash: 5.0p17 -> 5.0p18
3333139
dtzWill
dtzWill approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@dtzWill dtzWill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

pkgs/shells/bash/bash-5.0-patches.nix
@@ -18,4 +18,5 @@ patch: [
(patch "015" "0pm0px758w4i23s55wajcv6lqfiym7zgxvq0pxf6vclkv8nxy5x5")
(patch "016" "0vdha332km2iwx8g2ld15jy7d24cbplzgr1531dpzylr9ajxglgz")
(patch "017" "0cfw5lz3fcvq9h1fxihxvw940fjk68015jazvl8x8rlazgxbkwsc")
(patch "018" "1lw1vv0aj6x254hgx4klbz8qkvwxif0g6i7dx116cnhhb8vlwcbw")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sha256 confirmed, gpg sig checked manually 👍.

@dtzWill
Copy link
Member

dtzWill commented Oct 16, 2020

I would merge but I've been away for a short while and am a little trigger-shy 😇 (still catching up on workflow/etc changes/improvements).
But as far as I'm concerned this seems ready!
Thanks!

@NeQuissimus NeQuissimus merged commit b4586ea into NixOS:master Oct 16, 2020
@NeQuissimus NeQuissimus deleted the bash_50p18 branch October 16, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill dtzWill approved these changes

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NeQuissimus @dtzWill