Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildMaven: Update buildMaven to pure Nix #100634

Merged
merged 1 commit into from Oct 13, 2022
Merged

buildMaven: Update buildMaven to pure Nix #100634

merged 1 commit into from Oct 13, 2022

Conversation

fzakaria
Copy link
Contributor

@fzakaria fzakaria commented Oct 15, 2020 •
edited

Motivation for this change

Change the code that builds the maven repository to one using pure nix rather than a bash script.

❯nix-build --no-out-link example.nix -I nixpkgs=/home/fmzakari/code/github.com/NixOS/nixpkgs
/nix/store/5zg4jxj7897lcasd7zpvjrk8drnmiaf5-maven-repository

❯ tree /nix/store/5zg4jxj7897lcasd7zpvjrk8drnmiaf5-maven-repository | head

/nix/store/5zg4jxj7897lcasd7zpvjrk8drnmiaf5-maven-repository
├── antlr
│   └── antlr
│       └── 2.7.2
│           ├── antlr-2.7.2.jar -> /nix/store/d027c8f2cnmj5yrynpbq2s6wmc9cb559-antlr-2.7.2.jar
│           └── antlr-2.7.2.pom -> /nix/store/mv42fc5gizl8h5g5vpywz1nfiynmzgp2-antlr-2.7.2.pom
├── aopalliance
│   └── aopalliance
│       └── 1.0
│           ├── aopalliance-1.0.jar -> /nix/store/yy66cplfasm9m5r61hi09vbk4mkk47rl-aopalliance-1.0.jar
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

(Tagging recent committers to the file)
CC Maintainers: @charles-dyfis-net

@fzakaria
buildMaven: Update buildMaven to pure Nix
09abb91 
Change the code that builds the maven repository to one using pure nix
rather than a bash script.
@fzakaria
Copy link
Contributor Author

I ran nixfmt on the source as well, so that's the cause of the additional non-logical changes.

@stale
Copy link

stale bot commented Jun 3, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2021
@doronbehar doronbehar requested a review from shlevy August 10, 2021 05:43
@doronbehar
Copy link
Contributor

Wow it looks like a lot of effort has been put into this.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 10, 2021
@fzakaria
Copy link
Contributor Author

Yea it's been a while since I posted it. ☺️

I really like the link farm usage when I was using it since you can skip downloading artifacts if you change your pom file.

@stale
Copy link

stale bot commented Apr 19, 2022

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 19, 2022
@addict3d
Copy link
Contributor

This looks really great!

I have a project that could use it, but currently, I cannot give a timeline for when I might test that out.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 19, 2022
@shlevy shlevy merged commit ee7722a into NixOS:master Oct 13, 2022
@shlevy
Copy link
Member

shlevy commented Oct 13, 2022

Sorry for the delay, this looks good!

@zeratax zeratax mentioned this pull request Nov 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charles-dyfis-net charles-dyfis-net Awaiting requested review from charles-dyfis-net

@shlevy shlevy Awaiting requested review from shlevy

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fzakaria @doronbehar @addict3d @shlevy