Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: remove periods from end of package descriptions (part 2) #101649

Merged
merged 1 commit into from Oct 25, 2020
Merged

treewide: remove periods from end of package descriptions (part 2) #101649

merged 1 commit into from Oct 25, 2020

Conversation

siraben
Copy link
Member

@siraben siraben commented Oct 25, 2020

Motivation for this change

Part of #97685 until we get automatic checks in ofborg/GitHub actions. The PR #97835 managed to fix this for 260+ packages however there were still some remaining ones that had multiline/unusual descriptions. This PR fixes that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@siraben siraben changed the title treewide: remove periods from end of package descriptions treewide: remove periods from end of package descriptions (part 2) Oct 25, 2020
@bhipple
Copy link
Contributor

bhipple commented Oct 25, 2020

Result of nixpkgs-review pr 101649 1

@bhipple bhipple merged commit 19256a1 into NixOS:master Oct 25, 2020
@siraben siraben deleted the desc-fix branch October 25, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@siraben @bhipple