Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: ce383a198503
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: f4254fba4f27
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Oct 25, 2020

  1. test-driver.py: remove bufsize=1 from Popen calls 

    According to Python documentation [0], `bufsize=1` is only meaningful in
text mode. As we don't pass in an argument called `universal_newlines`,
`encoding`, `errors` or `text` the file objects aren't opened in text
mode, which means the argument is ignored with a warning in Python 3.8.

    line buffering (buffering=1) isn't supported in binary mode,
    the default buffer size will be used

This commit removes this warning that appared when using
interactive test driver built with `-A driver`. This is done by
removing `bufsize=1` from Popen calls.

The default parameter when unspecified for `bufsize` is `-1` which
according to the documentation will be interpreted as
`io.DEFAULT_BUFFER_SIZE`. As mentioned by a warning, Python already
uses default buffer size when providing `buffering=1` parameter for
file objects not opened in text mode.

[0]: https://docs.python.org/3/library/subprocess.html#subprocess.Popen
    @KamilaBorowska
    KamilaBorowska committed Oct 25, 2020
    Copy the full SHA
    254d30d View commit details
    Browse the repository at this point in the history

  2. Merge pull request #101538 from xfix/test-driver-bufsize 

    test-driver.py: remove bufsize=1 from Popen calls
    @tfc
    tfc committed Oct 25, 2020
    Copy the full SHA
    f4254fb View commit details
    Browse the repository at this point in the history