Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gopls: don't build integration tests or documentation generator #101641

Merged
merged 1 commit into from Oct 28, 2020
Merged

gopls: don't build integration tests or documentation generator #101641

merged 1 commit into from Oct 28, 2020

Conversation

lukegb
Copy link
Contributor

@lukegb lukegb commented Oct 25, 2020

Not only are these not used, but they also have super generic names,
which is confusing when they appear on the path, and possibly leads
to conflicts with other binaries.

Motivation for this change

The "gopls" package currently produces a directory containing three integration test binaries and a binary simply named "doc". The "doc" binary is particularly frustratating because it also conflicts with a similarly named binary in gotools.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Before:
$ nix path-info -f ./ -S gopls
/nix/store/373wla596ndqxygi0mr60q8wfid3y5bs-gopls-0.4.1	   62052208

After:
$ nix path-info -f ./ -S gopls
/nix/store/zb07swkmqckrk9jqzhrz9xvjpcpkfs0h-gopls-0.4.1	   53274680

SuperSandro2000
SuperSandro2000 approved these changes Oct 25, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick research and I think vimPlugins.vim-go which depends on gopls does not require those binaries.

@SuperSandro2000
Copy link
Member

@lukegb Can you please rebase on master to fix borg eval?

@lukegb
gopls: don't build integration tests or documentation generator
6a91f4b 
Not only are these not used, but they also have super generic names,
which is confusing when they appear on the path, and possibly leads
to conflicts with other binaries.
@ofborg ofborg bot requested review from kalbasit, Mic92 and zimbatm October 28, 2020 19:24
@zimbatm zimbatm merged commit a30a084 into NixOS:master Oct 28, 2020
@lukegb lukegb deleted the gopls-only branch December 5, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@rvolosatovs rvolosatovs rvolosatovs approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@Mic92 Mic92 Awaiting requested review from Mic92

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lukegb @SuperSandro2000 @rvolosatovs @zimbatm