Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/samba: fix race between network-online and winbindd #101652

Closed
wants to merge 1 commit into from
Closed

nixos/samba: fix race between network-online and winbindd #101652

wants to merge 1 commit into from

Conversation

jevankovich
Copy link

@jevankovich jevankovich commented Oct 25, 2020 •
edited

Motivation for this change

On startup, if winbindd starts before the network is up, name resolution will fail until winbindd is restarted.

See: Ubuntu bug

Things done

Add an ordering dependency between winbindd and network-online.target.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jevankovich
nixos/samba: fix race between network-online and winbindd
574b555 
On startup, if winbindd starts before the network is up, name resolution will fail until winbindd is restarted.

See more: https://bugs.launchpad.net/ubuntu/+source/samba/+bug/1789097
@AmandaCameron AmandaCameron mentioned this pull request Feb 25, 2021
Merged
10 tasks
@stale
Copy link

stale bot commented Apr 26, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 26, 2021
@bachp
Copy link
Member

bachp commented Mar 21, 2022

Solved by #114393

@bachp bachp closed this Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jevankovich @bachp @Janik-Haag