Python packages set: patch updates #101636

FRidh · 2020-10-25T09:10:33Z

Motivation for this change

$ maintainers/scripts/update-python-libraries --use-pkgs-prefix --commit --target=patch pkgs/development/python-modules/**/*.nix

Things done

SuperSandro2000 · 2020-10-25T12:38:36Z

pkgs/development/python-modules/boto3/default.nix

@@ -13,11 +13,11 @@

 buildPythonPackage rec {
  pname =  "boto3";
-  version = "1.15.9"; # N.B: if you change this, change botocore too
+  version = "1.15.18"; # N.B: if you change this, change botocore too


Suggested change

version = "1.15.18"; # N.B: if you change this, change botocore too

version = "1.15.18"; # N.B: if you change this, change boto3 and awscli to a matching version

SuperSandro2000 · 2020-10-25T12:42:15Z

Did you use a script to do this? Can I find it somewhere?

FRidh · 2020-10-25T12:44:45Z

@SuperSandro2000

$ maintainers/scripts/update-python-libraries --use-pkgs-prefix --commit --target=patch pkgs/development/python-modules/**/*.nix

mweinelt · 2020-10-25T14:14:34Z

The zipgy updates collide with #101557 and I'd like the maintainer to work on test integration in that pull request. They also require an update to home-assistants component-packages.nix, so I'd appreciate if you could drop them here.

mweinelt · 2020-10-25T14:41:36Z

builder for '/nix/store/zg8jl91486n45sz196s2z3zmxs74g36m-python3.8-amply-0.1.4.drv' failed with exit code 1; last 10 log lines:
  patching script interpreter paths in /nix/store/c81cvqg9yjzhvf3ff5b25kgxwzc0g8l2-python3.8-amply-0.1.4
  checking for references to /build/ in /nix/store/c81cvqg9yjzhvf3ff5b25kgxwzc0g8l2-python3.8-amply-0.1.4...
  Executing pythonRemoveTestsDir
  Finished executing pythonRemoveTestsDir
  running install tests
  Traceback (most recent call last):
    File "tests/test_amply.py", line 4, in <module>
      import pytest
  ModuleNotFoundError: No module named 'pytest'
  builder for '/nix/store/zg8jl91486n45sz196s2z3zmxs74g36m-python3.8-amply-0.1.4.drv' failed with exit code 1

https://github.com/willu47/amply/blame/v0.1.4/tests/test_amply.py#L4

jonringer · 2020-11-05T23:07:47Z

fridh, your pip reproducible patch isn't included in here. many packages are failing

jonringer · 2020-11-06T01:01:17Z

@FRidh I rebased this on top of the latest to bringing your fixes for builds affected by the pip reproducibility patch.

Unfortunately, I'm still affected by OpenMathLib/OpenBLAS#2970 and unable to build numpy (without disabling tests). So, I'll need to wait for hydra to build it for me to progress much further

EDIT:

actually, I'll just disable numpy tests locally and continue on with stabilizing

jonringer · 2020-11-06T05:33:22Z

this is probably more stable than master at this point

raboof · 2020-11-13T16:21:49Z

The pytest-testmon 1.0.2 -> 1.0.3 included in this change appears to fail consistently.

I'm no python programmer, but indeed looking at the PyPI package, test/test_core.py:131 expects filenames_fingerprints to contain 5 elements, but the query at testmon/testmon_core.py:267 only selects 4.

I don't see any tests in the source repo at https://github.com/tarpas/pytest-testmon, though, so it's unclear to me where these tests actually come from...

raboof · 2020-11-14T09:21:00Z

The pytest-testmon 1.0.2 -> 1.0.3 included in this change appears to fail consistently.

It seems the tests are expecting master instead of 1.0.3 (tarpas/pytest-testmon#158), let's skip them for now (#103786)

@jonringer

Pyspark switched to pinning py4j==0.10.9 with v3.0.0 - see this commit: https://github.com/apache/spark/\ commit/fc4e56a54c15e20baf085e6061d3d83f5ce1185d This meant that since the bump to pyspark v3.0.0 - in this commit: https://github.com/NixOS/nixpkgs/\ commit/5181547ae6624b462919a806c4d0888e6e4630f4 - the patch was no longer matching on the 'py4j==0.10.7' string that was working previously. The failing patch went unnoticed previously because the version of py4j pinned by pyspark>=3.0.0 was the same as the py4j provided by nixpkgs. However, a recent PR (NixOS#101636) bumped the version of py4j to 0.10.9.1 in this commit: https://github.com/NixOS/nixpkgs/\ commit/43a91282d66223c5cb978d53fbe1033f56dd7f2b which caused the version pinned by pyspark to no longer match the version provided by nixpkgs. FWIW, @jonringer flagged this issue on another PR that tried to bump py4j: NixOS#100623. My solution here was to upgrade the patch's target string to match the version found in pyspark's current setup.py.

@jonringer

Pyspark switched to pinning py4j==0.10.9 with v3.0.0 - see this commit: https://github.com/apache/spark/\ commit/fc4e56a54c15e20baf085e6061d3d83f5ce1185d This meant that since the bump to pyspark v3.0.0 - in this commit: https://github.com/NixOS/nixpkgs/\ commit/5181547ae6624b462919a806c4d0888e6e4630f4 - the patch was no longer matching on the 'py4j==0.10.7' string that was working previously. The failing patch went unnoticed previously because the version of py4j pinned by pyspark>=3.0.0 was the same as the py4j provided by nixpkgs. However, a recent PR (#101636) bumped the version of py4j to 0.10.9.1 in this commit: https://github.com/NixOS/nixpkgs/\ commit/43a91282d66223c5cb978d53fbe1033f56dd7f2b which caused the version pinned by pyspark to no longer match the version provided by nixpkgs. FWIW, @jonringer flagged this issue on another PR that tried to bump py4j: #100623. My solution here was to upgrade the patch's target string to match the version found in pyspark's current setup.py.

This was marked broken in NixOS#101636, which was merged into the staging branch. Later, the package was updated and fixed in NixOS#101801. When the staging branch was then merged into master, the package was marked as broken while actually being fixed.

FRidh requested a review from jonringer as a code owner October 25, 2020 09:10

FRidh mentioned this pull request Oct 25, 2020

pythonPackages.sqlalchemy: 1.3.19 -> 1.3.20 #101295

Closed

10 tasks

nbke mentioned this pull request Oct 25, 2020

pythonPackages.numpy: 1.19.1 -> 1.19.2 #101372

Closed

10 tasks

SuperSandro2000 reviewed Oct 25, 2020

View reviewed changes

SuperSandro2000 approved these changes Oct 25, 2020

View reviewed changes

FRidh force-pushed the python-unstable branch from 84fefff to bdc6028 Compare October 25, 2020 13:04

ofborg bot added 6.topic: python 8.has: documentation 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ labels Oct 25, 2020

FRidh force-pushed the python-unstable branch from bdc6028 to 7a753df Compare November 5, 2020 09:41

This was referenced Nov 5, 2020

Python-unstable "run" #102858

Closed

pythonPackages.pandas: 1.1.1 -> 1.1.4 & cleanup #98162

Closed

FRidh added 10 commits November 5, 2020 15:46

python3Packages.GitPython: 3.1.7 -> 3.1.11

2490755

python3Packages.adal: 1.2.4 -> 1.2.5

e5614a4

python3Packages.aiohttp: 3.6.2 -> 3.6.3

3c68887

python3Packages.alembic: 1.4.2 -> 1.4.3

73719b1

python3Packages.amazon_kclpy: 1.5.0 -> 1.5.1

6a9d91d

python3Packages.amply: 0.1.2 -> 0.1.4

495f158

python3Packages.apispec: 3.3.1 -> 3.3.2

037a766

python3Packages.astropy: 4.0.1.post1 -> 4.0.3

7343285

python3Packages.atlassian-python-api: 1.17.5 -> 1.17.6

a77a6a9

python3Packages.awkward1: 0.2.35 -> 0.2.38

841886b

jonringer force-pushed the python-unstable branch from eba59fc to fb67994 Compare November 6, 2020 00:58

jonringer mentioned this pull request Nov 6, 2020

Post 20.09 cleanup #101863

Closed

4 tasks

jonringer added 12 commits November 5, 2020 20:01

python3Packages.pandas: fix tests

8ba1cd2

python3Packages.rubymarshal: disable tests

aef2a4e

python2Packages.screeninfo: disable python2

90aa139

python3Packages.xdis: 5.0.4 -> 5.0.5

b715913

pythonPackages.ipdb: disable python2

2f82264

libsoup: fix build

6cfd954

python3Packages.periodictable: fix tests

db42905

python3Packages.deform: fix tests

18252b3

python3Packages.ipdb: add missing test deps

c9a5501

python3Packages.scramp: init at 1.2.0

9b69c08

python3Packages.pg8000: add missing deps

17f4011

python3Packages.google_auth: 1.20.1 -> 1.23.0

a4b1f04

ofborg bot added the 8.has: package (new) label Nov 6, 2020

FRidh merged commit 73f591a into staging Nov 6, 2020

jonringer mentioned this pull request Nov 8, 2020

python3Packages.jupytext: fix build by adding toml dep #103148

Closed

10 tasks

raboof mentioned this pull request Nov 13, 2020

mailutils: update guile to current version #103209

Merged

10 tasks

jonringer mentioned this pull request Nov 19, 2020

pythonPackages.feedparser: 5.2.1 -> 6.0.1 #101635

Closed

10 tasks

jskrzypek mentioned this pull request Nov 23, 2020

python3Packages.pyspark: Fix out of date postPatch #104723

Merged

10 tasks

Luflosi mentioned this pull request Feb 8, 2021

python3Packages.py-multihash: mark not broken #112410

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Python packages set: patch updates #101636

Python packages set: patch updates #101636

FRidh commented Oct 25, 2020 •

edited

SuperSandro2000 Oct 25, 2020

SuperSandro2000 commented Oct 25, 2020

FRidh commented Oct 25, 2020

mweinelt commented Oct 25, 2020

mweinelt commented Oct 25, 2020

jonringer commented Nov 5, 2020

jonringer commented Nov 6, 2020 •

edited

jonringer commented Nov 6, 2020

raboof commented Nov 13, 2020

raboof commented Nov 14, 2020

	version = "1.15.18"; # N.B: if you change this, change botocore too
	version = "1.15.18"; # N.B: if you change this, change boto3 and awscli to a matching version

Navigation Menu

Python packages set: patch updates #101636

Python packages set: patch updates #101636

Conversation

FRidh commented Oct 25, 2020 • edited

Motivation for this change

Things done

SuperSandro2000 Oct 25, 2020

Choose a reason for hiding this comment

SuperSandro2000 commented Oct 25, 2020

FRidh commented Oct 25, 2020

mweinelt commented Oct 25, 2020

mweinelt commented Oct 25, 2020

jonringer commented Nov 5, 2020

jonringer commented Nov 6, 2020 • edited

jonringer commented Nov 6, 2020

raboof commented Nov 13, 2020

raboof commented Nov 14, 2020

FRidh commented Oct 25, 2020 •

edited

jonringer commented Nov 6, 2020 •

edited