Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glances: add py-cpuinfo dependency #101639

Merged
merged 1 commit into from Oct 25, 2020
Merged

glances: add py-cpuinfo dependency #101639

merged 1 commit into from Oct 25, 2020

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Oct 25, 2020

Motivation for this change

This enables the Quicklook CPU info module.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Luflosi
glances: add py-cpuinfo dependency
b305338 
This enables the Quicklook CPU info module.
@mweinelt
Copy link
Member

Afte this change the CPU model became visible in the upper left corner. LGTM.

Result of nixpkgs-review pr 101639 1

1 package built:
  • glances

@mweinelt mweinelt merged commit 923ceda into NixOS:master Oct 25, 2020
@Luflosi Luflosi deleted the glances-add-py-cpuinfo branch October 25, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Luflosi @mweinelt @SuperSandro2000