Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python{2,3}Package.apprise: fix missing dependencies #100446

Merged
merged 3 commits into from Oct 25, 2020

Conversation

jfroche
Copy link
Contributor

@jfroche jfroche commented Oct 13, 2020

Motivation for this change

Add the missing dependencies

ZHF: #97479
@NixOS/nixos-release-managers

fix builds https://hydra.nixos.org/build/127627883 https://hydra.nixos.org/build/127621060 https://hydra.nixos.org/build/127648198

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jfroche jfroche changed the title pythonPackages.apprise: fix missing dependencies python{2,3}Package.apprise: fix missing dependencies Oct 13, 2020
@jfroche
Copy link
Contributor Author

jfroche commented Oct 13, 2020

Result of nixpkgs-review pr 100446 1

6 packages built:
  • python27Packages.apprise
  • python27Packages.gntp
  • python37Packages.apprise
  • python37Packages.gntp
  • python38Packages.apprise
  • python38Packages.gntp

@jonringer
Copy link
Contributor

If you're new to python packaging through nix, I got a video https://www.youtube.com/watch?v=jXd-hkP4xnU which covers most packaging scenarios.

@jfroche
Copy link
Contributor Author

jfroche commented Oct 14, 2020

If you're new to python packaging through nix, I got a video https://www.youtube.com/watch?v=jXd-hkP4xnU which covers most packaging scenarios.

Thank you, will watch it !

@risicle
Copy link
Contributor

risicle commented Oct 14, 2020

nixpkgs-review builds happily for me, macos 10.14

@jfroche
Copy link
Contributor Author

jfroche commented Oct 16, 2020

@jonringer this should be ok, maybe you are waiting for something I missed ?

@jfroche
Copy link
Contributor Author

jfroche commented Oct 18, 2020

Result of nixpkgs-review pr 100446 1

6 packages built:
  • python27Packages.apprise
  • python27Packages.gntp
  • python37Packages.apprise
  • python37Packages.gntp
  • python38Packages.apprise
  • python38Packages.gntp

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 100446 1

6 packages built:
  • python27Packages.apprise
  • python27Packages.gntp
  • python37Packages.apprise
  • python37Packages.gntp
  • python38Packages.apprise
  • python38Packages.gntp

@vcunat vcunat merged commit ed217bc into NixOS:master Oct 25, 2020
vcunat added a commit that referenced this pull request Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants