New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python{2,3}Package.apprise: fix missing dependencies #100446
Conversation
Result of 6 packages built:
|
c66caa6
to
5b8f695
Compare
If you're new to python packaging through nix, I got a video https://www.youtube.com/watch?v=jXd-hkP4xnU which covers most packaging scenarios. |
Thank you, will watch it ! |
nixpkgs-review builds happily for me, macos 10.14 |
@jonringer this should be ok, maybe you are waiting for something I missed ? |
Add the missing dependencies on gntp
Result of 6 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Result of nixpkgs-review pr 100446 1
6 packages built:
- python27Packages.apprise
- python27Packages.gntp
- python37Packages.apprise
- python37Packages.gntp
- python38Packages.apprise
- python38Packages.gntp
(cherry picked from commit ed217bc)
Motivation for this change
Add the missing dependencies
ZHF: #97479
@NixOS/nixos-release-managers
fix builds https://hydra.nixos.org/build/127627883 https://hydra.nixos.org/build/127621060 https://hydra.nixos.org/build/127648198
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)