Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brotli: 1.0.7 -> 1.0.9 #100436

Merged
merged 2 commits into from Oct 17, 2020
Merged

brotli: 1.0.7 -> 1.0.9 #100436

merged 2 commits into from Oct 17, 2020

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Oct 13, 2020

(cherry picked from commit 9d5a3f2e33ee28b2e32b3bdc41930d8725c2edee)

Motivation for this change

Upstream upgrade containing fix for a CVE:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@freezeboy
Copy link
Contributor Author

Changed destination to staging due to the number of dependencies to rebuild.

Relevant commit for review is: a33f7a7

(cherry picked from commit 9d5a3f2e33ee28b2e32b3bdc41930d8725c2edee)
(cherry picked from commit d41ae9ec1470f34b755766f9cbeeae5a32492760)
Co-authored-by: Samuel Ainsworth <skainsworth@gmail.com>
@vcunat vcunat self-assigned this Oct 17, 2020
@vcunat vcunat merged commit 347696a into NixOS:staging Oct 17, 2020
@vcunat
Copy link
Member

vcunat commented Oct 17, 2020

I squashed also because of the commit message referencing unreachable commits.

vcunat pushed a commit that referenced this pull request Oct 20, 2020
Fixes CVE-2020-8927.

(cherry picked from commit 347696a)
@freezeboy freezeboy deleted the update-brotli branch October 23, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants