Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trigger: 0.6.6 -> 0.6.6.1 #100449

Merged
merged 1 commit into from Oct 13, 2020
Merged

trigger: 0.6.6 -> 0.6.6.1 #100449

merged 1 commit into from Oct 13, 2020

Conversation

p-h
Copy link
Contributor

@p-h p-h commented Oct 13, 2020

Motivation for this change
  • Trigger doesn't build currently
  • Trigger is outdated
Things done
  • Updated trigger 0.6.6.1
  • added tinyxml-2 as dependency
  • fix linker flag for trigger
  • improved description
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@AndersonTorres
Copy link
Member

AndersonTorres commented Oct 13, 2020

Can you squash the commits here?

Also, we neeed a better description for it.

fix linker flag for trigger
added tinyxml-2 as dependency as it's not shipped anymore
improved description
@p-h
Copy link
Contributor Author

p-h commented Oct 13, 2020

done and done

@AndersonTorres AndersonTorres changed the title Trigger 0.6.6.1 trigger: 0.6.6 -> 0.6.6.1 Oct 13, 2020
@AndersonTorres AndersonTorres merged commit e3635b9 into NixOS:master Oct 13, 2020
@p-h p-h mentioned this pull request Oct 14, 2020
10 tasks
@p-h p-h deleted the trigger-0.6.6.1 branch October 14, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants