Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plater: init at 2020-07-30 #102995

Merged
merged 1 commit into from Nov 7, 2020
Merged

plater: init at 2020-07-30 #102995

merged 1 commit into from Nov 7, 2020

Conversation

lovesegfault
Copy link
Member

Motivation for this change

I need this for my 3D printer.

While they do have a 1.0 release that was before they got their build system
working well and fixed some major bugs, so I opted to package the last commit,
which I have tested to work.

cc. @flokli

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lovesegfault lovesegfault force-pushed the plater-init branch 2 times, most recently from c3b715c to 69f2533 Compare November 6, 2020 05:36
doronbehar
doronbehar requested changes Nov 6, 2020
View reviewed changes
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/plater/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/plater/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/plater/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/plater/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/plater/default.nix Outdated Show resolved Hide resolved
@lovesegfault
Copy link
Member Author

Made changes, thanks for the review @doronbehar!

doronbehar
doronbehar approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, and I'll merge unless you'd like to wait for flokli's approval.

@flokli
Copy link
Contributor

flokli commented Nov 6, 2020 via email

@lovesegfault
Copy link
Member Author

@flokli good catch! Fixed!

@flokli flokli merged commit c0f4be6 into NixOS:master Nov 7, 2020
@lovesegfault lovesegfault deleted the plater-init branch November 8, 2020 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lovesegfault @flokli @doronbehar