Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macvim: fix building with nix-daemon #102975

Merged
merged 1 commit into from Nov 6, 2020
Merged

macvim: fix building with nix-daemon #102975

merged 1 commit into from Nov 6, 2020

Conversation

lilyball
Copy link
Member

@lilyball lilyball commented Nov 6, 2020

Motivation for this change

MacVim fails to build in a multi-user setup with nix-daemon, as Xcode tries to place derived data into a path rooted in /var/empty. This PR works around this by specifying the derived data path manually.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I also tested building this on both a multi-user and a single-user setup.

@lilyball
macvim: fix building with nix-daemon
33b5abf 
When building MacVim with nix-daemon it tries to place the derived data
into a path rooted in `/var/empty`, which fails. Specifying the derived
data path ourselves fixes this problem.
@veprbl veprbl merged commit 93b0acc into NixOS:master Nov 6, 2020
@lilyball lilyball deleted the macvim branch November 7, 2020 00:05
@lilyball lilyball restored the macvim branch November 7, 2020 00:05
@lilyball lilyball deleted the macvim branch November 7, 2020 00:05
@lilyball lilyball restored the macvim branch November 7, 2020 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lilyball @veprbl