New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Record to ValueCastable, from UserValue #529
Conversation
48bd40b
to
239a295
Compare
Codecov Report
@@ Coverage Diff @@
## master #529 +/- ##
==========================================
- Coverage 81.39% 81.32% -0.08%
==========================================
Files 49 49
Lines 6440 6457 +17
Branches 1286 1288 +2
==========================================
+ Hits 5242 5251 +9
- Misses 1009 1015 +6
- Partials 189 191 +2
Continue to review full report at Codecov.
|
Co-authored-by: whitequark <whitequark@whitequark.org>
Also remove comment referring to Record as a Value
e0edddb
to
febbc90
Compare
Oh, a good addition to this PR would be to rip out every place where Record is treated somehow differently in the middle end and back end. (I don't think we have any in the front end.) |
I don't actually see any of those? A |
Oh right! We already ripped those out after we migrated it to |
This PR migrates Record from being based on UserValue to being based on ValueCastable, clearing the way to deprecate UserValue.
Would close #528 .