Codecov Report

Merging #529 into master will decrease coverage by 0.07%.
The diff coverage is 69.56%.

@@            Coverage Diff             @@
##           master     #529      +/-   ##
==========================================
- Coverage   81.39%   81.32%   -0.08%     
==========================================
  Files          49       49              
  Lines        6440     6457      +17     
  Branches     1286     1288       +2     
==========================================
+ Hits         5242     5251       +9     
- Misses       1009     1015       +6     
- Partials      189      191       +2     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06c7349...febbc90. Read the comment docs.

Oh, a good addition to this PR would be to rip out every place where Record is treated somehow differently in the middle end and back end. (I don't think we have any in the front end.)

I don't actually see any of those? A grep -R Record nmigen/ shows Record being used in a few places but I only see things of the form isinstance(x, Record) or similar in the RPC server and the compat layer, both of which I'd consider to be special cases.

I don't actually see any of those?

Oh right! We already ripped those out after we migrated it to UserValue.