Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] pythia: 8.244 -> 8.245 #102953

Merged
merged 1 commit into from Nov 6, 2020

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Nov 5, 2020

A bugfix release for 8.2 branch.

Motivation for this change

Provide a bugfix release for 8.2 branch. The nixpkgs master already uses 8.3.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

A bugfix release for 8.2 branch.
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102953 run on x86_64-linux 1

2 packages built:
  • pythia
  • sacrifice

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When backporting changes, please follow https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes.

Namely, you should be doing git cherry-pick -x <rev> from a commit that has already landed in master. If the branches have diverged, you may alter the commit or add another commit to ensure that the package is able to still evaluate and build

@jonringer
Copy link
Contributor

i guess master was bumped to 8.303

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/NixOS/nixpkgs/pull/102953
2 packages built:
pythia sacrifice

@jonringer jonringer merged commit f47129d into NixOS:release-20.09 Nov 6, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102953 run on x86_64-darwin 1

2 packages built:
  • pythia
  • sacrifice

@veprbl veprbl deleted the pr/pythia_8_245_20.09 branch December 1, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants