Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux-hardened: Do not block channel #102977

Merged
merged 1 commit into from Nov 6, 2020
Merged

linux-hardened: Do not block channel #102977

merged 1 commit into from Nov 6, 2020

Conversation

NeQuissimus
Copy link
Member

Motivation for this change

#102974
Do not block channel when the hardened kernels do not apply, we have had multiple issues recently.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@NeQuissimus NeQuissimus added 9.needs: port to stable A PR needs a backport to the stable release. 6.topic: testing Tooling for automated testing of packages and modules labels Nov 6, 2020
@andersk
Copy link
Contributor

andersk commented Nov 6, 2020

Should we remove nixos.tests.hardened too?

@NeQuissimus
Copy link
Member Author

@andersk No, I use the tests when I update things :)
The patches you pushed should also allow us to point the hardened kernel at 5.9, right?

@andersk
Copy link
Contributor

andersk commented Nov 6, 2020

Er to be clear, my question is whether we should remove nixos.tests.hardened from nixos/release-combined.nix, for the same reason you’ve removed nixos.tests.latestKernel.hardened from nixos/release-combined.nix. (I’m not saying delete the tests themselves.)

@NeQuissimus
Copy link
Member Author

Oh, I misunderstood! Yes, we should :)

@NeQuissimus NeQuissimus merged commit caf8d00 into NixOS:master Nov 6, 2020
NeQuissimus added a commit that referenced this pull request Nov 6, 2020
@NeQuissimus
Merge pull request #102977 from NeQuissimus/hardened_test
61daffa 
linux-hardened: Do not block channel
(cherry picked from commit caf8d00)
@NeQuissimus NeQuissimus deleted the hardened_test branch November 6, 2020 15:31
@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andersk andersk andersk approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: testing Tooling for automated testing of packages and modules 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NeQuissimus @andersk @erictapen