Skip to content

python3Packages.dotnetcore2: remove #102976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

jonringer
Copy link
Contributor

Motivation for this change

Added it as it was painful to package, but I've since felt like it shouldn't be in nixpkgs.

It's a hack to essentially treat pypi like a binary package installer... instead of doing a command -v dotnet || echo "please install dotnet" to check if it's needed.

Outdated, and new package isn't trivial to package anymore.
Not really useful outside of Azure Machine Learning anyway.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mweinelt Martin Weinelt
Outdated, and new package isn't trivial to package anymore.
Not really useful outside of Azure Machine Learning anyway.
@jonringer jonringer requested a review from FRidh as a code owner November 6, 2020 01:24
@ofborg ofborg bot added 6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 6, 2020
@jonringer jonringer merged commit 37c564a into NixOS:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant