Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ldc: 1.20.1 -> 1.24.0 #102964

Merged
merged 1 commit into from Nov 7, 2020
Merged

ldc: 1.20.1 -> 1.24.0 #102964

merged 1 commit into from Nov 7, 2020

Conversation

fabianhjr
Copy link
Member

@fabianhjr fabianhjr commented Nov 5, 2020 •
edited

Things done

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from lionello November 5, 2020 20:51
@lionello
Copy link
Contributor

lionello commented Nov 6, 2020

Fails here on Darwin for me:

llvm-config: unknown component name: windowsmanifest
CMake Error at cmake/Modules/FindLLVM.cmake:50 (message):
  Failed to execute llvm-config
  ('/nix/store/9g4chijh9255y65vf3nsgg9258knli58-llvm-5.0.2/bin/llvm-config',
  result code: '1)'
Call Stack (most recent call first):
  cmake/Modules/FindLLVM.cmake:97 (_LLVM_FAIL)
  cmake/Modules/FindLLVM.cmake:122 (llvm_set_libs)
  CMakeLists.txt:34 (find_package)


-- Configuring incomplete, errors occurred!
See also "/private/var/folders/d5/5ybzst6d2wbggcfhkjwl56s80000gn/T/nix-build-ldc-1.24.0.drv-0/ldc-1.24.0-src/build/CMakeFiles/CMakeOutput.log".
builder for '/nix/store/5k9zp5dzbw8s09qlv4a5jlv34s3hz0zh-ldc-1.24.0.drv' failed with exit code 1
error: build of '/nix/store/5k9zp5dzbw8s09qlv4a5jlv34s3hz0zh-ldc-1.24.0.drv' failed

@fabianhjr
Copy link
Member Author

Hi @lionello, could you try removing the LLVM 5 version for macos and check if it works with LLVM 11?

@lionello
Copy link
Contributor

lionello commented Nov 6, 2020

Hi @lionello, could you try removing the LLVM 5 version for macos and check if it works with LLVM 11?

That worked! Good call.

@lionello lionello mentioned this pull request Nov 6, 2020
Closed
10 tasks
@fabianhjr
Copy link
Member Author

Thanks @lionello , then I will remove the language split between linux and darwin.

@fabianhjr
Copy link
Member Author

Ok, updated MacOS to LLVM 11

@ofborg ofborg bot requested a review from lionello November 6, 2020 15:50
@ofborg ofborg bot requested a review from lionello November 6, 2020 17:29
@lionello
Copy link
Contributor

lionello commented Nov 7, 2020

@worldofpeace could you help merge this?

@danieldk danieldk merged commit 126e5c1 into NixOS:master Nov 7, 2020
@fabianhjr fabianhjr deleted the update-ldc branch November 7, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lionello lionello lionello approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabianhjr @lionello @danieldk